-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to list to show column with state #102
Conversation
I am not super familiar with the package so I am not sure about that, but if you have some documentation about the |
I see that there is no change in tests. Because there are no tests on this part. Would it be the case to add a couple of tests for the |
@ClaudioSalvatoreArcidiacono That's one of the main things missing in this project: tests. We still didn't try to find a good way to test these functions. I guess this will have to be done with mock classes that could mimic the replies from the azure devops APIs. We could also try something even simpler, to begin with, and just check that we are sending out the correct API requests. Not really sure what's the best way to go about it. |
I usually use httmock for such kind of things. It is great :) |
But for the functions you modified, you do not really need to mock the http layer. You could just check the Table object that is returned by |
I added a test, but just for the new functionality added by this PR. I will fix the import sorting in a different PR, since there are more files that need reorganizing. I'll also add isort to the pre commit hooks :) And probably remove mypy :P |
Co-authored-by: Claudio Salvatore Arcidiacono <[email protected]>
Thanks for the comments! Much appreciated! |
Solves one of the open items from #94