Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add isort hook; run pre-commit hooks w/ GitHub Actions #104

Merged
merged 4 commits into from
Feb 23, 2022
Merged

add isort hook; run pre-commit hooks w/ GitHub Actions #104

merged 4 commits into from
Feb 23, 2022

Conversation

operte
Copy link
Collaborator

@operte operte commented Feb 23, 2022 •
edited
Loading

  • Added isort hook to pre-commit, following suggestion from @ClaudioSalvatoreArcidiacono on add option to list to show column with state #102.
  • Noticed that while we configure pre-commit hooks, we don't actually run them on GitHub Actions. We were just running pyflakes, which is not even one of the pre-commit hooks.
  • We had a lot of exceptions for flake8 which were unnecessary, so I cleaned that up.
  • Removed mypy from hooks.

@ClaudioSalvatoreArcidiacono
Copy link
Contributor

@operte operte merged commit aa7e30b into main Feb 23, 2022
@operte operte deleted the add-isort branch February 23, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@operte @ClaudioSalvatoreArcidiacono