Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite imports to include the /v2 suffix for version 2 #17607

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

jsternberg
Copy link
Contributor

Fixes #16872.

@jsternberg jsternberg requested a review from a team as a code owner April 3, 2020 17:44
@jsternberg jsternberg requested review from bthesorceror and removed request for a team April 3, 2020 17:44
@jsternberg jsternberg merged commit f09ee88 into master Apr 3, 2020
@jsternberg jsternberg deleted the refactor/rewrite-imports branch April 3, 2020 20:12
@44px
Copy link

44px commented Jun 25, 2020

Can this changes break installation of influxdb-relay?

Seems like Go complaining on import and package path mismatch:

$ go get -u github.com/influxdata/influxdb-relay

src/github.com/influxdata/influxdb/models/points.go:18:2: code in directory /go/src/github.com/influxdata/influxdb/pkg/escape expects import "github.com/influxdata/influxdb/pkg/escape"

Is there a workaround for this error?

Also may be related: influxdata/influxdb-relay#79

@vgrozev
Copy link

vgrozev commented Jul 14, 2020

Is there a workaround for this problem. I am looking for a way to install influxdb-relay?

@jsternberg
Copy link
Contributor Author

@44px if you enable go modules, it should retrieve dependencies that are compatible. You can also use gdm to restore the dependencies that are in the Godeps file. I put up influxdata/influxdb-relay#80 to make this easier in the future by adding a go.mod file to the repository.

@vgrozev can you show me what steps you are doing and how they are failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go module for v2 needs to end in "v2".
4 participants