fix: v2.0.0 needs a /v2 on the go.mod module #17502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.x requires a /v2 at the end of the module in go.mod. When trying to import ```github.com/influxdata/influxdb/v2 v2.0.0-beta.7``` The error message ```go: github.com/influxdata/influxdb/[email protected]: go.mod has non-.../v2 module path "github.com/influxdata/influxdb" (and .../v2/go.mod does not exist) at revision v2.0.0-beta.7``` is received.
nikgibbens
changed the title
|
@nikgibbens thanks for the contribution. could you sign the CLA while i find someone to review? https://influxdata.com/community/cla/ |
|
closes: #16872 |
|
Thank you for your contribution. For us to make this change, we need to also rewrite all of the ways the import is used and we also need to perform that rewrite on our internal codebase that uses this one as a library. We are going to do that process today starting in a few hours. Thanks for bringing this to our attention to keep us honest on this. We had been planning to do this for awhile, but just never pushed the button on the transition. I'm going to close this. The staging zone for merging this same change is in #17607. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.x requires a /v2 at the end of the module in go.mod.
When trying to import
github.com/influxdata/influxdb/v2 v2.0.0-beta.7The error message
go: github.com/influxdata/influxdb/[email protected]: go.mod has non-.../v2 module path "github.com/influxdata/influxdb" (and .../v2/go.mod does not exist) at revision v2.0.0-beta.7is received.
Closes #
Describe your proposed changes here.