Feature/code updates #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZvonimirMedak
added
documentation
nikolamajcen
approved these changes
Jan 8, 2025
|
|
||
| // MARK: - ErrorView | ||
|
|
||
| private struct ErrorView: View { |
There was a problem hiding this comment.
I would recommend putting this into a new file and make it internal (no need to add that modifier explicitly), but to make it visible to internal implementation (e..g, if needed in other modules).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the code style a bit, and added a part of the public documentation
Related issue: None
Changes
Type
Additional information
Description
Obj-c compatibility was removed since it was partially removed with the SwiftUI support.
Omitting a couple of returns, moving the code to new files/extensions, and adding some documentation.
Checklist
Additional notes