-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/swiftui support #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ZvonimirMedak, amazing job! You did a heavy-lifting regarding the project update and its support for SwiftUI.
Still, I've added some comments regarding the implementation - please check them out. Alongside that, please check the usage of Objective-C and remove it from the project (this will also affect some classes which are subclasses of NSObject
).
Note: I was unable to build the project due to multiple files (NavigationToolTableItem
duplication and location issues).
Hi @nikolamajcen, I left a question regarding the Extension MARKs, and we can sync later on regarding the fonts. If you want me to merge the #44 before you review this one again just let me know 😄 |
Hey @ZvonimirMedak, I'm fine with merging #44 before this one so that I can check the final implementation with removal and updates for the mentioned parts of the code (e.g., obj-c support, etc.). Regarding the unused |
Feature/code updates
Hi @nikolamajcen, please take a look again 🤞 |
Additionally, check the Bitrise and fix tests issue - in short, change the current minimum version from iOS 18 to iOS 14.0 on the Everything else looks really nice! Great work 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go 🚀
Summary
This PR adds SwiftUI support to the Sentinel library, with the refactor of the currently available tools to SwiftUI.
There are a lot of files changed, but some of them are minor changes, and some of them have been deleted
Related issue: None
Changes
Type
Additional information
Description
This PR contains three major updates to the current state of the library:
.custom
case which adds support for a custom View, and behaviorChecklist
Additional notes
The code documentation will be added in a separate PR