Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2270: Migrate FI-1990, fix flicker #409

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Conversation

AlyssaWang
Copy link
Collaborator

Summary

Prevent components from rendering until suite options, waiting test ID, and selection panel width are loaded in. Fixes flickering on new test session creation.

Testing Guidance

  1. From inside a session in a suite with no options, start a new session by clicking the header. The new session should start with no intermediate flickering.

  2. Repeat but with a suite with options. The screen should display without the description changing width. Try with small screen and large screen.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (59af6a0) 77.06% compared to head (ce1d4d2) 76.99%.

Files Patch % Lines
...c/components/SuiteOptionsPage/SuiteOptionsPage.tsx 0.00% 10 Missing ⚠️
client/src/components/TestSuite/TestSession.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   77.06%   76.99%   -0.07%     
==========================================
  Files         218      218              
  Lines       10878    10886       +8     
  Branches     1018     1018              
==========================================
- Hits         8383     8382       -1     
- Misses       1917     1926       +9     
  Partials      578      578              
Flag Coverage Δ
backend 93.82% <ø> (ø)
frontend 69.61% <26.66%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through the recommended test steps and it worked as expected in firefox.

@AlyssaWang AlyssaWang merged commit 3ac23dc into main Dec 19, 2023
9 of 10 checks passed
@AlyssaWang AlyssaWang deleted the FI-2270-migrate-1990 branch December 19, 2023 16:41
@rpassas rpassas mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants