Draft: FI-1990: Update landing page layout

[AlyssaWang]

Update 11/1/2023

PR to be reworked to merge in relevant fixes without major changes to landing/suite page styles

Summary

Cleaning up the landing page layout and workflow, removes the SuiteOptionsPage and associated router logic.

Testing Guidance

Check that all functionality still works. Open to feedback about workflow and layout!

Try redirecting from the app header:

• If a suite has no options and no description, a new session will start.
• If a suite has options, then the landing page with selected suite as default AND options will display.
• Otherwise the landing page with selected suite as default will display.

Try refreshing the page on each of the options. If a suite has no options and no description, it will redirect to a new session, otherwise same behavior as above.

[codecov]

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (545caf4) 77.00% compared to head (c10807c) 77.86%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   77.00%   77.86%   +0.85%     
==========================================
  Files         214      211       -3     
  Lines       10708    10656      -52     
  Branches      991     1022      +31     
==========================================
+ Hits         8246     8297      +51     
+ Misses       1884     1760     -124     
- Partials      578      599      +21     

Flag	Coverage Δ
backend	94.35% <ø> (ø)
frontend	70.92% <64.77%> (+1.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
client/src/components/Header/styles.tsx	97.56% <100.00%> (-0.06%)	⬇️
client/src/components/App/Router.tsx	90.32% <90.00%> (+7.82%)	⬆️
client/src/components/LandingPage/styles.tsx	96.29% <93.75%> (+4.62%)	⬆️
client/src/components/_common/BackButton.tsx	61.90% <66.66%> (+3.57%)	⬆️
..._common/SelectionPanel/__mocked_data__/mockData.ts	89.36% <75.00%> (+0.47%)	⬆️
...omponents/_common/SelectionPanel/ListSelection.tsx	85.41% <66.66%> (-1.07%)	⬇️
...mponents/_common/SelectionPanel/SelectionPanel.tsx	84.37% <78.26%> (+0.02%)	⬆️
client/src/components/LandingPage/LandingPage.tsx	65.28% <58.85%> (-18.40%)	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arscan]

I think the only critical issue I found is that if you jump straight to a test kit with options, you can't just 'start testing' unless you change the form, which is a problem if you want to just use the defaults which is what most people would want. So they would have to change one of the options and then back.

Minor issues (that I only bring up because they are directly in ONCs line of site and when they notice something has changed might be a bit more critical):

• "About ONC Certification (g)(10) Standardized API" is awkward to me. I think we should just remove the 'About'.
• I really dislike floating scrollbars that aren't anchored to some kind of visual container (see the above). I know that this is the same as before, though it might show up a bit quicker because that now has a max-width of 500 instead of ~580 looks like. I don't have an obvious solution because I think I understand why it is there, but in general in the future it would be good if we could avoid that kind of thing :)

[AlyssaWang]

Fixed the default suite options bug and removed "About" from the title. Not sure if there's a good way to fix the scrollbar issue.

[AlyssaWang]

Closing due to #409 being merged.