Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mecha resprite and Vim rework #1252

Merged
merged 9 commits into from
Jan 7, 2025
Merged

Conversation

kipdotnet
Copy link

@kipdotnet kipdotnet commented Jan 7, 2025

mom said its my turn to resprite things
resprites the Ripley and Vim, and allows goblins to pilot them. please dont be evil about this so I dont have to nerf it
Changelog

🆑

  • tweak: The Vim and Ripley now have new sprites.
  • tweak: Goblins can now pilot a Vim.
  • tweak: the Ripley APLU now has a slightly more decent melee attack.

@mutanteggs
Copy link

please don't put a module slot on the Vim. the vim doesn't need to be more than a fun toy that you can put your pets in to be a little safer. it doesn't need utility. please don't power creep it.

@kipdotnet
Copy link
Author

Thats fair. Should I drop the resprite as well, then?

@mutanteggs
Copy link

Thats fair. Should I drop the resprite as well, then?

unless the module is like, a huge part of the resprite, no way, don't waste that work you did. the headlights and the resprite are cool!

@hivehum
Copy link

hivehum commented Jan 7, 2025

dropping the module slot is fine but i think the resprite and allowing vims to be piloted by goblins and apids is fine personally. i dont think this is a power creep situation (what is it... power creeping...? what items are becoming less useful by reworking vims...?)

much more controversial changes in here like substantially buffing ripley dps

@hivehum
Copy link

hivehum commented Jan 7, 2025

oh actually you only tagged goblins as vim pilots and not apids. did you mean to tag both? i know that was in the previous pr

@kipdotnet
Copy link
Author

Theyre actually already pilotable by apids since they imhereted that when I based their original version off of punpun. Punpun can also pilot a vim apparently. And yeah I should make note of the ripley damage change I forgot to put it in the pr notes

@iaada
Copy link

iaada commented Jan 7, 2025

As a rule of thumb if you recognize people can be evil with something, you probably shouldn't give it to them. Mods have enough to moderate, and something as difficult to notice as a Vim carrying 8 crates is going to get missed.

I think there ought to be a whitelist for modules equippable by vim, and specific vim modules. A hydraulic clamp with only one slot, the H.O.N.K. horn but without all the dangerous sounds. Small things that thematically fit the size and cost of a vim.

@kipdotnet
Copy link
Author

Yeah. in a world that was pure and beautiful there would be more than TWO entire mech equipments in the game and I could whitelist nonimpactful ones but. for now ill just make it 0 slots

@kipdotnet
Copy link
Author

Ok I cut the ripley melee down to more reasonable numbers, removed the vims module slot and fixed the licensing. this should be good to look over again if anyone wants to yell at me more

Copy link

@Darkmajia Darkmajia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have a ripley melee meta i'm coming for you

@Darkmajia Darkmajia merged commit 783ec60 into impstation:master Jan 7, 2025
5 checks passed
@kipdotnet
Copy link
Author

If people use the ripley more its going to be because the sprite is so niceys. I hope. Its like a 10% buff or something

@kipdotnet kipdotnet deleted the i-love-to-dance branch January 7, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants