fix(server): queue missing metadata #15864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextran1502
approved these changes
Feb 3, 2025
jrasm91
reviewed
Feb 4, 2025
|
Just checked and thumbnail already seems to be correct. I'll see what I can do about the rest.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the kysely migration, we don't correctly queue the job of missing metadata.
If we upload a bunch of assets and restart the server before the metadata queue was finished, the asset_job_status table won't be populated with all assets. Then, the job looks for rows in that table that doesn't have metadata extraction run.
However, if the rows are never added this will return too few assets to queue, and those rows are only added at the end of metadata extraction.
Consequence: Assets with missing metadata don't get re-run unless you run the metadata job for all assets
Also added e2e tests for the job queue related to this.