feat(server): e2e for missing jobs #15910
Draft
+471
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnoy
force-pushed
the
fix/missing-thumbs
branch
from
be01600 to
602230b
Compare
…missing-thumbs
mertalev
reviewed
Feb 5, 2025
There was a problem hiding this comment.
This PR doesn't really fix anything. Metadata extraction is different because it's the first job that inserts into the job status table. The other jobs all expect metadata extraction to have run already, so there's nothing wrong with assuming there's a job status row for these assets.
etnoy
force-pushed
the
fix/missing-thumbs
branch
2 times, most recently
from
88b50f3 to
855c5ca
Compare
etnoy
changed the title
etnoy
force-pushed
the
fix/missing-thumbs
branch
4 times, most recently
from
dca3f96 to
1144737
Compare
etnoy
force-pushed
the
fix/missing-thumbs
branch
from
1144737 to
53660aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up on #15864 that improves the e2e tests and adds more tests for more jobs
Adds slightly more logging to job queue actions
Adds ML to e2e docker compose
Tests will fail until immich-app/test-assets#16 is merged
Should not be merged before we have a caching way to do e2e tests with ML