-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide better access to local ImageJ2 installation #89
Merged
gselzer
merged 10 commits into
main
from
16-allow-users-to-specify-their-imagej-distribution
Aug 16, 2022
Merged
Provide better access to local ImageJ2 installation #89
gselzer
merged 10 commits into
main
from
16-allow-users-to-specify-their-imagej-distribution
Aug 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gselzer
force-pushed
the
16-allow-users-to-specify-their-imagej-distribution
branch
21 times, most recently
from
August 10, 2022 19:26
3014591
to
16ff442
Compare
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 93.36% 92.48% -0.88%
==========================================
Files 15 17 +2
Lines 2501 2849 +348
==========================================
+ Hits 2335 2635 +300
- Misses 166 214 +48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gselzer
force-pushed
the
16-allow-users-to-specify-their-imagej-distribution
branch
3 times, most recently
from
August 10, 2022 19:58
9692ef5
to
775b104
Compare
gselzer
force-pushed
the
16-allow-users-to-specify-their-imagej-distribution
branch
3 times, most recently
from
August 15, 2022 13:56
e27ab3d
to
07c7b43
Compare
This commit squashed many WIP commits made during the development of this functionality. The main developments of this commit: * The ability to provide a local ImageJ2 installation instead of using a fresh installation * The ability to show the ImageJ(2) GUI to perform a bunch of ImageJ stuff at once * Buttons to transfer napari layers to/from ImageJ2
gselzer
force-pushed
the
16-allow-users-to-specify-their-imagej-distribution
branch
3 times, most recently
from
August 15, 2022 14:57
3c5da59
to
933f874
Compare
TODO before merge:
|
gselzer
force-pushed
the
16-allow-users-to-specify-their-imagej-distribution
branch
6 times, most recently
from
August 16, 2022 13:42
3db0b83
to
40f3620
Compare
Now, starting up the buttons DOESN'T block until ImageJ is ready! Also, we switch to icons only since it's more napari-like
Well, sometimes. What I've actually done is provide a setting that lets the user choose whether to just use the active layer or to prompt the user to choose the layer to be transferred. I figured this was the best middle ground between the two, especially since I had implementations of both coded.
We'll just squish the ImageJ2 GUI stuff into the main widget
gselzer
force-pushed
the
16-allow-users-to-specify-their-imagej-distribution
branch
from
August 16, 2022 14:30
e65000b
to
17f87d8
Compare
gselzer
deleted the
16-allow-users-to-specify-their-imagej-distribution
branch
August 16, 2022 16:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the ability for users to:
Limitations:
Service
implementation (right @ctrueden?), but I don't know which yet.Run
ning BigDataViewer presents the startup screen, but pressingBrowse
to search for an XML file will freeze both the popup and napari more generally, requiring me to kill napari. Is there a way that we can disclaim the limitations of third-party plugins if we can't support all of them?TODO:
Closes both #16 and #43