Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify their ImageJ distribution #16

Closed
gselzer opened this issue Mar 31, 2022 · 3 comments · Fixed by #89
Closed

Allow users to specify their ImageJ distribution #16

gselzer opened this issue Mar 31, 2022 · 3 comments · Fixed by #89
Milestone

Comments

@gselzer
Copy link
Collaborator

gselzer commented Mar 31, 2022

@ctrueden says (in #14):

I'd much rather create a napari-trackmate plugin or so instead of trying to shoehorn that functionality into this plugin.

That is fair, and I think I agree. But I do think you should be able to, with napari-imagej and no other napari plugins installed, initialize your ImageJ2 with whatever init string you want (including a locally wrapped ImageJ2 installation if desired). That way, people can invoke Fiji plugins with the search bar, for example—they just won't magically gain additional data structure conversions beyond those fundamentally supported. But for the vast majority of such plugins, they won't need anything extra.

Hmm, how do we add this functionality without it becoming an annoyance? If I just want stock ImageJ would I want to click through a startup screen every time I want to start the plugin? I'd prefer that this was some setting you could specify.

Maybe we could have an "napari-imagej-startup" plugin that allows you to modify where your imagej comes from? 😆

@ctrueden
Copy link
Member

ctrueden commented Apr 1, 2022

how do we add this functionality without it becoming an annoyance?

napari needs an options dialog, a la ImageJ2 OptionsPlugins. Then plugins could register typed options displayed in a dialog with components by magicgui.

And until then: next to the search bar we could add a little ⚙ button for bringing up the plugin's options.

@gselzer
Copy link
Collaborator Author

gselzer commented Apr 1, 2022

@tlambert03 do you have an opinion on this?

@tlambert03
Copy link

this is in the works. see https://github.com/napari/npe2/blob/main/npe2/manifest/contributions/_configuration.py ... which allows exactly this... it just hasn't been exposed in the contributions points yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants