Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCH-2125 - Open Validation Function #6

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

danielle-casella-adams
Copy link
Contributor

@danielle-casella-adams danielle-casella-adams commented Jul 23, 2024

Summary of PR changes

Allow the validation function to be used by other workflows. Allow for line numbers not being present and not sending in annotation options.

This will allow the validate-all-catalog-info-files action to reuse the same validation function without generating the validationMetadata object for every file it wants to validate. It also makes it so we aren't creating annotations on the catalog-info files it processes in bulk.

PR Requirements

  • For major, minor, or breaking changes, at least one of the commit messages contains the appropriate +semver: keywords.
    • See the Incrementing the Version section of the repository's README.md for more details.
  • The action code does not contain sensitive information.

NOTE: If the repo's workflow could not automatically update the README.md, it should be updated manually with the next version. For javascript actions, if the repo's workflow could not automatically recompile the action it should also be updated manually as part of the PR.

Allow the validation function to be used by other workflows.  Allow for line numbers not being present and not sending in annotation options.
@danielle-casella-adams danielle-casella-adams requested a review from a team as a code owner July 23, 2024 20:56
Copy link

The action's Contributing Guidelines have been met:

  • The action's version in the Usage Examples section of README.md has been updated to @v1.0.3
  • The action has been recompiled (if needed) by running the build command from the root of the repository

@JosephDSchwartz JosephDSchwartz dismissed their stale review July 23, 2024 21:16

Need to checks something then I'll re-approve

@danielle-casella-adams danielle-casella-adams merged commit 0fa5426 into main Jul 23, 2024
10 checks passed
@danielle-casella-adams danielle-casella-adams deleted the validation-tweaks branch July 23, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants