Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCH-2126 - Add domain props #5

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Conversation

danielle-casella-adams
Copy link
Contributor

@danielle-casella-adams danielle-casella-adams commented Jul 22, 2024

Summary of PR changes

  • Updating schema for Domain entity
  • Adding a regex pattern to the Entity metadata.name. These are the constraints backstage has.
  • Adding some additional props to testing for API & Component (I missed adding these in the last PR Adding addresses metadata to Component and API kinds #4 )

PR Requirements

  • For major, minor, or breaking changes, at least one of the commit messages contains the appropriate +semver: keywords.
    • See the Incrementing the Version section of the repository's README.md for more details.
  • The action code does not contain sensitive information.

NOTE: If the repo's workflow could not automatically update the README.md, it should be updated manually with the next version. For javascript actions, if the repo's workflow could not automatically recompile the action it should also be updated manually as part of the PR.

@danielle-casella-adams danielle-casella-adams requested a review from a team as a code owner July 22, 2024 22:00
Copy link

The action's Contributing Guidelines have been met:

  • The action's version in the Usage Examples section of README.md has been updated to @v1.0.2
  • The action has been recompiled (if needed) by running the build command from the root of the repository

Copy link

The action's Contributing Guidelines have been met:

  • The action's version in the Usage Examples section of README.md has been updated to @v1.0.2
  • The action has been recompiled (if needed) by running the build command from the root of the repository

Copy link

The action's Contributing Guidelines have been met:

  • The action's version in the Usage Examples section of README.md has been updated to @v1.0.2
  • The action has been recompiled (if needed) by running the build command from the root of the repository

@danielle-casella-adams danielle-casella-adams merged commit c64c4fb into main Jul 23, 2024
10 checks passed
@danielle-casella-adams danielle-casella-adams deleted the add-domain-props branch July 23, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants