Clean removes generated docs #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthew-Mosior
changed the title
andrevidela
reviewed
Jul 27, 2024
src/Idris/Package.idr
Outdated
| let build = build_dir (dirs (options defs)) | ||
| let docBase = build </> "docs" | ||
| let docDir = docBase </> "docs" | ||
| () <- do Right docfiles' <- coreLift $ listDir docDir |
There was a problem hiding this comment.
Looks great! Can we refactor the two do-blocks in their own auxiliary function?
There was a problem hiding this comment.
Thank you! That sounds good, should be resolved via ccff608.
There was a problem hiding this comment.
Sorry that's not quite what I meant, the two functions you put in auxiliary definitions are essentially the same, except for the file path, it would be nice to remove this redundancy.
There was a problem hiding this comment.
Ah I see! I think I've addressed this with d788e07.
There was a problem hiding this comment.
Not sure why this test is failing ...
6 tasks
|
@andrevidela I think this should be ready for you now :) |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
--cleanto remove documentation generated via--mkdoc.This addresses one of the tasks in #1918.