Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issues of the --mkdoc command #1918

Open
4 of 6 tasks
gallais opened this issue Sep 12, 2021 · 2 comments
Open
4 of 6 tasks

Known issues of the --mkdoc command #1918

gallais opened this issue Sep 12, 2021 · 2 comments
Labels
backend: html good first issue Good for newcomers status: confirmed bug Something isn't working

Comments

@gallais
Copy link
Member

gallais commented Sep 12, 2021

In case people want to have a look, the bulk of the command is implemented
in Idris.Doc.String (for the :doc command that the --mkdoc command reuses)
and Idris.Doc.HTML.

Copy/pasted from the original PR (#903):

  • types are not shown where they should be
    (although most of the time, the type is in the first line of the documentation)
    [NDLA: Not sure what this means?]
  • "documentation" is currently just a <pre> tag with the output equivalent to :doc in the REPL
  • namespace members are sorted alphabetically, this may not be the best choice
    [NDLA e.g. we could use file position instead to have a more scope-friendly presentation.
    This would also allow us to include things like headers in between sections]
  • --clean does not remove the generated docs
  • code needs some cleanup (and probably moved into a separate file, as it pollutes
    Package.idr with lots of HTML output-specific code, which will get worse as more
    features are implemented)

Additional issues:

  • Each doc file corresponds to a physical file and only contains the definitions in that
    exact namespace. We should either fully embrace the namespace-based approach and have
    one file per namespace or make sure the doc file also contains the definitions introduced
    in a nested namespace
@gallais gallais added good first issue Good for newcomers status: confirmed bug Something isn't working backend: html labels Sep 12, 2021
@gallais
Copy link
Member Author

gallais commented Apr 13, 2022

#2411 addresses

  1. alphabetical order of definitions (now changed to FC's startPos order)
  2. content of namespace rather than source file

@Matthew-Mosior
Copy link
Contributor

#3353 addresses --clean does not remove the generated docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: html good first issue Good for newcomers status: confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants