Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BAT and BMS pages #344

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

MSECode
Copy link
Member

@MSECode MSECode commented Mar 25, 2024

Update info regarding the BAT protocol after addition of new values of current and input voltage and update of timing definition in the documentation
Add specific page for BMS with info and messages send by BMS and with images for connections to ems
Refactor pages structure for all battery related board

@MSECode MSECode requested a review from pattacini as a code owner March 25, 2024 15:00
@MSECode MSECode self-assigned this Mar 25, 2024
@MSECode MSECode requested a review from valegagge March 25, 2024 15:01
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pattacini pattacini linked an issue Mar 25, 2024 that may be closed by this pull request
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MSECode.
I'll review the PR in the next few days.

@MSECode
Copy link
Member Author

MSECode commented Mar 26, 2024

Thank you @MSECode. I'll review the PR in the next few days.

Thanks @pattacini

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MSECode

I've provided several refinements to improve readability plus some inline comments that require your attention (which I tried to highlight using alerts).

docs/battery_boards/bat_board/bat_board.md Outdated Show resolved Hide resolved
docs/battery_boards/bat_board/bat_board.md Outdated Show resolved Hide resolved
docs/battery_boards/bat_board/bat_board.md Outdated Show resolved Hide resolved
docs/battery_boards/bat_board/bat_board.md Outdated Show resolved Hide resolved
docs/battery_boards/bat_board/bat_board.md Outdated Show resolved Hide resolved
docs/battery_boards/bms_board/bms_board.md Outdated Show resolved Hide resolved
docs/battery_boards/bms_board/bms_board.md Outdated Show resolved Hide resolved
docs/battery_boards/bms_board/bms_board.md Outdated Show resolved Hide resolved
docs/battery_boards/bms_board/bms_board.md Outdated Show resolved Hide resolved
docs/battery_boards/bms_board/bms_board.md Outdated Show resolved Hide resolved
Update info regarding the BAT protocol
after addition of new values of current and input voltage
and update of timing definition in the documentation
Add specific page for BMS with info and messages
send by BMS and with images for connections to ems
Update warning message for battery temperature value in BAT
Add review suggestions

Co-authored-by: Ugo Pattacini <[email protected]>
@pattacini pattacini merged commit 1b6c855 into icub-tech-iit:master Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Battery documenation
3 participants