-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BAT and BMS pages #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MSECode.
I'll review the PR in the next few days.
Thanks @pattacini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MSECode
I've provided several refinements to improve readability plus some inline comments that require your attention (which I tried to highlight using alerts).
1816054
to
0dac72d
Compare
Update info regarding the BAT protocol after addition of new values of current and input voltage and update of timing definition in the documentation Add specific page for BMS with info and messages send by BMS and with images for connections to ems Update warning message for battery temperature value in BAT Add review suggestions Co-authored-by: Ugo Pattacini <[email protected]>
0dac72d
to
5451e7c
Compare
Update info regarding the BAT protocol after addition of new values of current and input voltage and update of timing definition in the documentation
Add specific page for BMS with info and messages send by BMS and with images for connections to ems
Refactor pages structure for all battery related board