Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant conditional #590

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Remove redundant conditional #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions icepyx/core/APIformatting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,6 @@ def build_params(self, **kwargs):
self._fmted_keys.update({key: kwargs[key]})
except KeyError:
self._fmted_keys.update({key: kwargs["product"]})
elif key == "version":
self._fmted_keys.update({key: kwargs["version"]})
elif key in kwargs:
self._fmted_keys.update({key: kwargs[key]})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For key == "version", this branch does the same thing as the removed branch.

elif key in defaults:
Expand Down