Remove redundant conditional #590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will automatically update this comment whenever this PR is modified |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #590 +/- ##
===============================================
+ Coverage 65.37% 65.41% +0.04%
===============================================
Files 36 36
Lines 3038 3036 -2
Branches 531 530 -1
===============================================
Hits 1986 1986
+ Misses 970 969 -1
+ Partials 82 81 -1 ☔ View full report in Codecov by Sentry. |
mfisher87
commented
Aug 27, 2024
| @@ -393,8 +393,6 @@ def build_params(self, **kwargs): | |||
| self._fmted_keys.update({key: kwargs[key]}) | |||
| except KeyError: | |||
| self._fmted_keys.update({key: kwargs["product"]}) | |||
| elif key == "version": | |||
| self._fmted_keys.update({key: kwargs["version"]}) | |||
| elif key in kwargs: | |||
| self._fmted_keys.update({key: kwargs[key]}) | |||
There was a problem hiding this comment.
For key == "version", this branch does the same thing as the removed branch.
mfisher87
added
the
review::quick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conditional is handled by the next one in the chain.