Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve trip reminder notification #197

Merged
merged 12 commits into from
Dec 4, 2023
Merged

Improve trip reminder notification #197

merged 12 commits into from
Dec 4, 2023

Commits on Nov 28, 2023

  1. improvement(TripMonitorNotification): Separate initial notif addon te… 

    …xt if no other notifs.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    8a59bb3 View commit details
    Browse the repository at this point in the history

  2. fix(CheckMonitoredTrip): Add initial reminder after other check logic.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    bf224d1 View commit details
    Browse the repository at this point in the history

  3. refactor(TripMonitorNotification): Add and use ctor when creating not… 

    …ification instances.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2cfff4a View commit details
    Browse the repository at this point in the history

  4. improvement(CheckMonitoredTrip): Place initial reminder text at top o… 

    …f notifications.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e8adc1b View commit details
    Browse the repository at this point in the history

  5. improvement(TripMonitorNotifications): Improve notification text

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    27efbf4 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. refactor(TripMonitorNotification): Remove the initial reminder text a… 

    …bout "We'll let you know..."
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    d3e9b9f View commit details
    Browse the repository at this point in the history

  2. test(TripMonitorNotification): Add test file for sort order.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    7264908 View commit details
    Browse the repository at this point in the history

  3. refactor(TripMonitorNotification): Add comment for comparator/sort fu… 

    …nction.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    20b65d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Adriana Ceric <[email protected]>
    @binh-dam-ibigroup @AdrianaCeric
    binh-dam-ibigroup and AdrianaCeric authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    58abc20 View commit details
    Browse the repository at this point in the history

  2. test(CheckMonitoredTripTest): Update tests with new notifi text.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    5762624 View commit details
    Browse the repository at this point in the history

  3. test(CheckMonitoredTripTest): Remove exclamation points

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    142d6fb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into improve-trip-reminder-notif

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    2bf1020 View commit details
    Browse the repository at this point in the history