Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve trip reminder notification #197

Merged
merged 12 commits into from
Dec 4, 2023
Merged

Improve trip reminder notification #197

merged 12 commits into from
Dec 4, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Nov 28, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • [na] The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR makes the following improvements to the initial reminder notification:

  • That notification now always appear first
  • The portion reading "We will let you know if anything changes" is only shown if there are no other notifications.

@binh-dam-ibigroup binh-dam-ibigroup marked this pull request as draft November 28, 2023 20:31
@binh-dam-ibigroup binh-dam-ibigroup marked this pull request as ready for review November 28, 2023 22:26
AdrianaCeric
AdrianaCeric approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few comments

JymDyerIBI
JymDyerIBI approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@binh-dam-ibigroup binh-dam-ibigroup merged commit 162bca9 into dev Dec 4, 2023
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the improve-trip-reminder-notif branch December 4, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianaCeric AdrianaCeric AdrianaCeric approved these changes

@JymDyerIBI JymDyerIBI JymDyerIBI approved these changes

Assignees

@JymDyerIBI JymDyerIBI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @AdrianaCeric @JymDyerIBI