Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent overwriting trip/user internal fields #195

Merged
merged 8 commits into from
Nov 27, 2023
Merged

Prevent overwriting trip/user internal fields #195

merged 8 commits into from
Nov 27, 2023

Commits on Nov 20, 2023

  1. fix(MonitoredTripController): Protect computed MonitoredTrip fields f… 

    …rom overwrite.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    54ccad7 View commit details
    Browse the repository at this point in the history

  2. fix(AbstractUserController): Prevent some OtpUser fields from being w… 

    …ritten from web request.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    f8cdc36 View commit details
    Browse the repository at this point in the history

  3. test(GetMonitoredTripsTest): Add test around not overwriting fields.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    f096879 View commit details
    Browse the repository at this point in the history

  4. test(GetNonitoredTripsTest): Delete trip after creation in tests.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    9f1a4c1 View commit details
    Browse the repository at this point in the history

  5. fix(MonitoredTrip): Remove JsonIgnore from tripTime, refactor tests.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    9023ba3 View commit details
    Browse the repository at this point in the history

  6. fix(MonitoredTrip): Remove JsonIgnore from arriveBy.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    3ecdfa9 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. refactor(MonitoredTrip): Apply back JsonIgnore to arriveBy and tripTi… 

    …me, update tests.
    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    18d05db View commit details
    Browse the repository at this point in the history

  2. test(GetMonitoredTripTest): Add assertion for null tripTime field.

    @binh-dam-ibigroup
    binh-dam-ibigroup committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    677076e View commit details
    Browse the repository at this point in the history