-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent overwriting trip/user internal fields #195
Merged
binh-dam-ibigroup
merged 8 commits into
dev
from
prevent-overwriting-trip-user-internal-fields
Nov 27, 2023
Merged
Prevent overwriting trip/user internal fields #195
binh-dam-ibigroup
merged 8 commits into
dev
from
prevent-overwriting-trip-user-internal-fields
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ritten from web request.
…me, update tests.
JymDyerIBI
reviewed
Nov 21, 2023
src/main/java/org/opentripplanner/middleware/controllers/api/AbstractUserController.java
Show resolved
Hide resolved
JymDyerIBI
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
br648
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look goods. I was unable to run the updated test because of Auth0 config. I'll assume the tests are fine because they pass CI.
binh-dam-ibigroup
deleted the
prevent-overwriting-trip-user-internal-fields
branch
November 27, 2023 19:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
dev
before they can be merged tomaster
)Description
Web requests that missed certain fields in
MonitoredTrip
could mess up the stored state of those trips,resulting in, for instance, errors in the trip monitoring checks and loss of push notifications.
This PR addresses that issue by preventing a number of internal fields in
MonitoredTrip
andOtpUser
from being modified via web requests.