Prevent overwriting trip/user internal fields #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ritten from web request.
…me, update tests.
JymDyerIBI
reviewed
Nov 21, 2023
src/main/java/org/opentripplanner/middleware/controllers/api/AbstractUserController.java
Show resolved
Hide resolved
br648
approved these changes
Nov 22, 2023
binh-dam-ibigroup
deleted the
prevent-overwriting-trip-user-internal-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Web requests that missed certain fields in
MonitoredTripcould mess up the stored state of those trips,resulting in, for instance, errors in the trip monitoring checks and loss of push notifications.
This PR addresses that issue by preventing a number of internal fields in
MonitoredTripandOtpUserfrom being modified via web requests.