IBX-9627: Replaced Symfony code quality set with specific rules #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
adamwojs
approved these changes
Feb 27, 2025
ciastektk
approved these changes
Feb 27, 2025
wiewiurdp
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This is a follow-up to #24. Code quality Symfony Set List proved to be too volatile. For example, it removes
Actionsuffix from controllers while not updating controller configuration YAMLs, which makes it not suitable for automated CI jobs.Instead, I've chosen 3 Rectors from that set list, which provide a value:
EventListenerToEventSubscriberRectorLiteralGetToRequestClassConstantRector// converts'GET'literals to use a const from SFResponseStatusCodeRector// converts HTTP status codes to use a const from SF