IBX-9627: Replaced Symfony code quality set with specific rules (#27)

For more details see https://issues.ibexa.co/browse/IBX-9627 and #27 Key changes: * Dropped volatile Symfony code quality Rector set * Configured directly chosen rules from Symfony code quality Rector set * [Tests] Aligned IbexaRectorConfigFactoryTest with the changes
ibexa · Feb 27, 2025 · 1257477 · 1257477
1 parent f5cf01f
commit 1257477
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/contracts/Factory/IbexaRectorConfigFactory.php b/src/contracts/Factory/IbexaRectorConfigFactory.php
@@ -11,6 +11,9 @@
 use Ibexa\Contracts\Rector\Sets\IbexaSetList;
 use Rector\Config\RectorConfig;
 use Rector\Configuration\RectorConfigBuilder;
+use Rector\Symfony\CodeQuality\Rector\BinaryOp\ResponseStatusCodeRector;
+use Rector\Symfony\CodeQuality\Rector\Class_\EventListenerToEventSubscriberRector;
+use Rector\Symfony\CodeQuality\Rector\MethodCall\LiteralGetToRequestClassConstantRector;
 use Rector\Symfony\Set\SymfonySetList;
 
 final readonly class IbexaRectorConfigFactory implements IbexaRectorConfigFactoryInterface
@@ -28,6 +31,13 @@ public function createConfig(): RectorConfigBuilder
     {
         return RectorConfig::configure()
            ->withPaths($this->pathsToProcess)
+           ->withRules(
+               [
+                   EventListenerToEventSubscriberRector::class,
+                   LiteralGetToRequestClassConstantRector::class,
+                   ResponseStatusCodeRector::class,
+               ]
+           )
            ->withSets(
                array_merge(
                    [
@@ -39,7 +49,6 @@ public function createConfig(): RectorConfigBuilder
                        SymfonySetList::SYMFONY_52_VALIDATOR_ATTRIBUTES,
                        SymfonySetList::SYMFONY_53,
                        SymfonySetList::SYMFONY_54,
-                       SymfonySetList::SYMFONY_CODE_QUALITY,
                        SymfonySetList::SYMFONY_CONSTRUCTOR_INJECTION,
                        SymfonySetList::SYMFONY_60,
                        SymfonySetList::SYMFONY_61,

diff --git a/tests/contracts/IbexaRectorConfigFactoryTest.php b/tests/contracts/IbexaRectorConfigFactoryTest.php
@@ -16,6 +16,9 @@
 use Rector\Configuration\Parameter\SimpleParameterProvider;
 use Rector\Symfony\Set\SymfonySetList;
 
+/**
+ * @covers \Ibexa\Contracts\Rector\Factory\IbexaRectorConfigFactory
+ */
 final class IbexaRectorConfigFactoryTest extends TestCase
 {
     /**
@@ -46,7 +49,6 @@ public static function getSetsForIbexaConfigFactory(): iterable
             SymfonySetList::SYMFONY_52,
             SymfonySetList::SYMFONY_53,
             SymfonySetList::SYMFONY_54,
-            SymfonySetList::SYMFONY_CODE_QUALITY,
             SymfonySetList::SYMFONY_CONSTRUCTOR_INJECTION,
             SymfonySetList::SYMFONY_60,
             SymfonySetList::SYMFONY_61,