generated from ibexa/bundle-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-9627: Implemented Ibexa Rector config factory #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
commented
Feb 24, 2025
SymfonySetList::SYMFONY_53, | ||
SymfonySetList::SYMFONY_54, | ||
SymfonySetList::SYMFONY_CODE_QUALITY, | ||
SymfonySetList::SYMFONY_CONSTRUCTOR_INJECTION, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this one is about container->get
usages in favor of direct service injection.
adamwojs
reviewed
Feb 24, 2025
konradoboza
reviewed
Feb 25, 2025
Co-authored-by: Adam Wójs <[email protected]>
konradoboza
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 but readonly
should be probably moved to each class property.
Co-authored-by: Adam Wójs <[email protected]>
Co-authored-by: Konrad Oboza <[email protected]>
b250fce
to
dcc29ed
Compare
ciastektk
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
To avoid repetition of
rector.php
contents in all packages, related to enabling Rector on CI, introducingIbexaConfigRectorFactory
SPI.Usage:
That way if Rector sets change, we can change it here instead of in all packages.