Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9627: Implemented Ibexa Rector config factory #24

Merged
merged 5 commits into from
Feb 25, 2025
Merged

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Feb 24, 2025

🎫 Issue IBX-9627

Related PRs:

Description:

To avoid repetition of rector.php contents in all packages, related to enabling Rector on CI, introducing IbexaConfigRectorFactory SPI.

Usage:

use Ibexa\Contracts\Rector\Factory\IbexaRectorConfigFactory;

return (new IbexaRectorConfigFactory(
    [
        __DIR__ . '/src',
        __DIR__ . '/tests',
    ]
))->createConfig();

That way if Rector sets change, we can change it here instead of in all packages.

SymfonySetList::SYMFONY_53,
SymfonySetList::SYMFONY_54,
SymfonySetList::SYMFONY_CODE_QUALITY,
SymfonySetList::SYMFONY_CONSTRUCTOR_INJECTION,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this one is about container->get usages in favor of direct service injection.

@alongosz alongosz requested a review from a team February 24, 2025 18:29
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but readonly should be probably moved to each class property.

@alongosz alongosz merged commit f5cf01f into main Feb 25, 2025
3 checks passed
@alongosz alongosz deleted the ibx-9627-rector-ci branch February 25, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants