Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(acl): fix duplicate groot user creation #9041

Merged
merged 9 commits into from
Jun 6, 2024
Merged

fix(acl): fix duplicate groot user creation #9041

merged 9 commits into from
Jun 6, 2024

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Mar 1, 2024 •
edited by shivaji-kharse
Loading

This PR adds the unique directive to the 'dgraph.xid' predicate. Prior to this change, users could create duplicate users leading to misconfiguration of ACL.

@mangalaman93 mangalaman93 requested a review from a team as a code owner March 1, 2024 06:52
@dgraph-bot dgraph-bot added area/testing Testing related issues area/enterprise Related to proprietary features area/schema Issues related to the schema language and capabilities. area/graphql Issues related to GraphQL support on Dgraph. area/enterprise/acl Related to Access Control Lists area/core internal mechanisms go Pull requests that update Go code labels Mar 1, 2024
@mangalaman93 mangalaman93 changed the title fix(acl): fix duplicate groot user creation (#51) fix(acl): fix duplicate groot user creation Mar 1, 2024
mangalaman93
mangalaman93 commented Mar 26, 2024
View reviewed changes
testutil/client.go Outdated Show resolved Hide resolved
systest/integration2/acl_test.go Show resolved Hide resolved
dgraphtest/paths.go Outdated Show resolved Hide resolved
dgraphtest/ee.go Outdated Show resolved Hide resolved
dgraphtest/ee.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
@shivaji-kharse shivaji-kharse force-pushed the aman/8c968c891 branch 2 times, most recently from 6b76bc6 to fcfddbe Compare March 27, 2024 13:55
mangalaman93
mangalaman93 commented Mar 28, 2024
View reviewed changes
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
dgraphtest/paths.go Outdated Show resolved Hide resolved
mangalaman93
mangalaman93 commented Apr 18, 2024
View reviewed changes
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
mangalaman93
mangalaman93 commented Apr 19, 2024
View reviewed changes
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/dgraph.go Outdated Show resolved Hide resolved
testutil/client.go Outdated Show resolved Hide resolved
@shivaji-kharse shivaji-kharse force-pushed the aman/8c968c891 branch 2 times, most recently from 7f4b1e6 to 82193f7 Compare April 29, 2024 13:16
@shivaji-kharse shivaji-kharse force-pushed the aman/8c968c891 branch 3 times, most recently from b296a22 to 766ddf5 Compare May 21, 2024 04:46
shivaji-kharse and others added 3 commits May 31, 2024 13:16
@shivaji-kharse
fix(acl): fix duplicate groot user creation (#51)
b15fd8d 
This PR adds the unique directive to the 'dgraph.xid' predicate. Prior to this change, users could
create duplicate users leading to misconfiguration of ACL.
@shivaji-kharse
fix failing tests
32973b0
@shivaji-kharse
add script to log duplicate users and groups
fc5c502
mangalaman93
mangalaman93 commented May 31, 2024
View reviewed changes
check_upgrade/check_upgrade_test.go Outdated Show resolved Hide resolved
schema/schema.go Show resolved Hide resolved
schema/schema.go Outdated Show resolved Hide resolved
mangalaman93
mangalaman93 commented Jun 3, 2024
View reviewed changes
Copy link
Member Author

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. get an approval from @harshil-goel

@meghalims meghalims merged commit 42115e4 into main Jun 6, 2024
13 checks passed
@meghalims meghalims deleted the aman/8c968c891 branch June 6, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivaji-kharse shivaji-kharse shivaji-kharse left review comments

@harshil-goel harshil-goel harshil-goel approved these changes

Assignees
No one assigned
Labels
area/core internal mechanisms area/enterprise/acl Related to Access Control Lists area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/schema Issues related to the schema language and capabilities. area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mangalaman93 @harshil-goel @shivaji-kharse @dgraph-bot @meghalims