fix(acl): fix duplicate groot user creation (#51)

This PR adds the unique directive to the 'dgraph.xid' & 'dgraph.graphql.xid' predicates. Prior to this change, users could create duplicate users leading to misconfiguration of ACL.
hypermodeinc · Mar 1, 2024 · fff5058 · fff5058
1 parent 3754e87
commit fff5058
Show file tree

Hide file tree

Showing 10 changed files with 362 additions and 144 deletions.
diff --git a/dgraphtest/ee.go b/dgraphtest/ee.go
@@ -123,7 +123,7 @@ func (hc *HTTPClient) CreateGroup(name string) (string, error) {
 	}
 	resp, err := hc.RunGraphqlQuery(params, true)
 	if err != nil {
-		return "", nil
+		return "", err
 	}
 	type Response struct {
 		AddGroup struct {

diff --git a/ee/acl/acl_integration_test.go b/ee/acl/acl_integration_test.go
@@ -412,6 +412,7 @@ func (asuite *AclTestSuite) TestWrongPermission() {
 	defer cleanup()
 	require.NoError(t, gc.LoginIntoNamespace(ctx, dgraphtest.DefaultUser,
 		dgraphtest.DefaultPassword, x.GalaxyNamespace))
+	require.NoError(t, gc.DropAll())
 
 	mu := &api.Mutation{SetNquads: []byte(`
 	_:dev <dgraph.type> "dgraph.type.Group" .