Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tezos signer service #1416

Closed
wants to merge 2 commits into from
Closed

Add tezos signer service #1416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5270ad5
DA-515 Add tezos signer service to manifestgen.sh
denisandreenko Oct 11, 2023
87c938b
DA-515 Update manifest
denisandreenko Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@
},
"evmconnect": {
"image": "ghcr.io/hyperledger/firefly-evmconnect",
"tag": "v1.3.0",
"sha": "cddfbe3a67a660e72a35e79af931625fdc1a285c2ea97faef68ad0408aa0d8c3"
"tag": "v1.3.1",
"sha": "fdac5c853a73d97f7c9c7b56a4fa07a5bad4f5574568aa399e71427fba8d7094"
},
"fabconnect": {
"image": "ghcr.io/hyperledger/firefly-fabconnect",
"tag": "v0.9.17",
"sha": "7d4aa158f9dff31f200ae7a04f68665f32930f7739156b25a0da80e5353f3245"
"tag": "v0.9.18",
"sha": "683b4ef1373b3d9decd591906298878561218489a6279c3f4f208e2e1c7ace3f"
},
"tezosconnect": {
"image": "ghcr.io/hyperledger/firefly-tezosconnect",
"tag": "v0.1.0",
"sha": "2c20731765f9203fceca6e28a5fa443e4ce5c3a9eb1de7710ed46f8e24db1c00"
"tag": "v0.1.1",
"sha": "cc7332644d15ebf2959870911cfda1a038eb41e3a9a4aa121b73877f2b143071"
},
"dataexchange-https": {
"image": "ghcr.io/hyperledger/firefly-dataexchange-https",
Expand All @@ -36,8 +36,13 @@
},
"signer": {
"image": "ghcr.io/hyperledger/firefly-signer",
"tag": "v1.1.9",
"sha": "515271ea722e6bf9601524880e7280a1fc052453733338d6ed474f85d6618aa1"
"tag": "v1.1.10",
"sha": "a06502872afda77d2a8c11a38a59c1c7b0eccc9ca3e7845711a2e2d6b98d31d2"
},
"tezossigner": {
"image": "ecadlabs/signatory",
"tag": "v1.1.10",
"sha": "2a48567c22af3ad9eb5860c1e29b1dea8aa73a7889e0e779fdfd7b882ae1458a"
Comment on lines +42 to +45
Copy link
Contributor

@nguyer nguyer Oct 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Signatory needs to go in the manifest.json. Currently, the manifest.json is used for the following two reasons:

  • Lists the images/tags of FireFly services (within the Hyplerledger project) that should be tested together
  • Lists the images/tags of the containers used to compile FireFly core and its smart contracts

Currently, we do not list other third party services that may be required in some configurations. For example, we don't list specific versions of Besu, Geth, Fabric, etc. We also don't list a specific Postgres image, even though it is a requirement if you're not using SQLite. I tend to think of Signatory as falling in the same bucket. It's a runtime that is outside the project, but may be required as a runtime dependency in certain configurations.

In reality, FireFly is probably compatible with a wide range of versions of these services and we want to allow end users to upgrade FireFly independently of third-party services. The idea behind the manifest.json is if you are going to upgrade FireFly here is the list of images that you should upgrade. How and when you upgrade third party services is up to you.

},
"build": {
"firefly-builder": {
Expand Down
13 changes: 13 additions & 0 deletions manifestgen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,19 @@ do
echo " }," >> manifest.json
done

# Add an external tezos signer service
echo " \"tezossigner\": {" >> manifest.json
echo " \"image\": \"ecadlabs/signatory\"," >> manifest.json
docker pull ecadlabs/signatory:latest
SHA=$(docker inspect --format='{{index .RepoDigests 0}}' ecadlabs/signatory:latest | cut -d ':' -f 2)
TAG_LABEL=$(docker inspect --format='{{index .Config.Labels "tag"}}' ecadlabs/signatory:latest)
if [ -z "$TAG_LABEL" ]; then
TAG_LABEL=$TAG
fi
echo " \"tag\": \"$TAG_LABEL\"," >> manifest.json
echo " \"sha\": \"$SHA\"" >> manifest.json
echo " }," >> manifest.json

# Add the build and UI sections, piping to sed to get proper indentation
echo "\"build\": $BUILD_SECTION," | sed 's/^/ /' >> manifest.json
echo "\"ui\": $UI_SECTION," | sed 's/^/ /' >> manifest.json
Expand Down
Loading