Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tezos signer service #1416

Closed

Conversation

denisandreenko
Copy link
Member

The tezos signer service will be running as a part of the FF stack for tezos flow which is responsible for transactions signing process

@denisandreenko denisandreenko requested a review from a team as a code owner October 11, 2023 09:43
@codecov-commenter
Copy link

Codecov Report

Merging #1416 (87c938b) into main (b3443ec) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1416   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         321      321           
  Lines       23027    23027           
=======================================
  Hits        23025    23025           
  Misses          1        1           
  Partials        1        1           

Comment on lines +42 to +45
"tezossigner": {
"image": "ecadlabs/signatory",
"tag": "v1.1.10",
"sha": "2a48567c22af3ad9eb5860c1e29b1dea8aa73a7889e0e779fdfd7b882ae1458a"
Copy link
Contributor

@nguyer nguyer Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Signatory needs to go in the manifest.json. Currently, the manifest.json is used for the following two reasons:

  • Lists the images/tags of FireFly services (within the Hyplerledger project) that should be tested together
  • Lists the images/tags of the containers used to compile FireFly core and its smart contracts

Currently, we do not list other third party services that may be required in some configurations. For example, we don't list specific versions of Besu, Geth, Fabric, etc. We also don't list a specific Postgres image, even though it is a requirement if you're not using SQLite. I tend to think of Signatory as falling in the same bucket. It's a runtime that is outside the project, but may be required as a runtime dependency in certain configurations.

In reality, FireFly is probably compatible with a wide range of versions of these services and we want to allow end users to upgrade FireFly independently of third-party services. The idea behind the manifest.json is if you are going to upgrade FireFly here is the list of images that you should upgrade. How and when you upgrade third party services is up to you.

@denisandreenko denisandreenko deleted the manifest/tezos_signer branch October 30, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants