Virtual channel watching and dispute test (Last part of large Virtual Channel PR) #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgeihs
force-pushed
the
82-virtual-channels
branch
4 times, most recently
from
f10d622
to
9c316fd
Compare
matthiasgeihs
force-pushed
the
82-virtual-channels
branch
14 times, most recently
from
5005e3f
to
30dfd5a
Compare
matthiasgeihs
commented
Jun 17, 2021
matthiasgeihs
commented
Jun 17, 2021
matthiasgeihs
commented
Jun 17, 2021
matthiasgeihs
commented
Jun 17, 2021
matthiasgeihs
commented
Jun 17, 2021
matthiasgeihs
force-pushed
the
82-virtual-channels
branch
2 times, most recently
from
f192508
to
3f17b82
Compare
matthiasgeihs
commented
Jun 18, 2021
matthiasgeihs
force-pushed
the
82-virtual-channels
branch
2 times, most recently
from
d57cf7d
to
08a965c
Compare
matthiasgeihs
force-pushed
the
82-virtual-channels
branch
4 times, most recently
from
3c254ec
to
2af1137
Compare
matthiasgeihs
changed the title
matthiasgeihs
commented
Jul 7, 2021
ggwpez
suggested changes
Jul 7, 2021
This was referenced Jun 14, 2022
matthiasgeihs
force-pushed
the
82-virtual-channels
branch
2 times, most recently
from
72687d8
to
e4de987
Compare
ggwpez
suggested changes
Jul 8, 2021
matthiasgeihs
force-pushed
the
82-virtual-channels
branch
from
de45c91
to
1764f43
Compare
Preparation for virtual channel watching. Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Use logFunder, logAdjudicator instead of DummyFunder, DummyAdjudicator Reduce size of codebase. Reduce redundant parts. Merge logFunder and logFunderWithDelay. Merge logFunder and logAdjudicator into logBackend. Reduce code complexity. Prepare changes that would require adjudicator logic based on the funder state. Signed-off-by: Matthias Geihs <[email protected]>
- Register: Emit events for sub-channels, add state and sigs - Subscribe: Only return events for a given channel. - Withdraw: Print accumulated outcome. Also rename to mockBackend because it actually does more than just logging. Signed-off-by: Matthias Geihs <[email protected]>
Usage before was clunky. The user needed to gather subchannels manually and to know which function to call. Now the framework does that for the user. Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
82-virtual-channels
branch
from
c3218dc
to
2d9efe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After splitting up the Virtual channel PR into several smaller, but still not small, PRs, this should now be the last one of that series. It contains:
Closes #82