-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 82 virtual channels #114
Merged
ggwpez
merged 9 commits into
hyperledger-labs:dev
from
perun-network:prepare-82-virtual-channels
Jun 22, 2021
Merged
Prepare 82 virtual channels #114
ggwpez
merged 9 commits into
hyperledger-labs:dev
from
perun-network:prepare-82-virtual-channels
Jun 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
prepare-82-virtual-channels
branch
from
June 18, 2021 12:52
a0d0c65
to
ea250c2
Compare
ggwpez
reviewed
Jun 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit structure makes it easy to follow 👍
Signed-off-by: Matthias Geihs <[email protected]>
This enables the framework to distinguish between standard channel update messages and funding or settlement update messages. Signed-off-by: Matthias Geihs <[email protected]>
Because it contains not just watching, but also registering, progressing, and settling. Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
prepare-82-virtual-channels
branch
from
June 21, 2021 07:34
ea250c2
to
c05d177
Compare
ggwpez
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting some commits from #83 .