Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close channel automatically when settling #139

Open
matthiasgeihs opened this issue Jul 8, 2021 · 0 comments
Open

Close channel automatically when settling #139

matthiasgeihs opened this issue Jul 8, 2021 · 0 comments

Comments

@matthiasgeihs
Copy link
Contributor

matthiasgeihs commented Jul 8, 2021

Related to #83 (comment)_

Problem: Closing a channel involves calling channel.Settle and channel.Close. It is easy to mix up the two, or forget to call one of them, and I don't see a case where I want to do one without the other.

Suggestion: Always close when settling.

Important: Closing a channel deletes it from the registry. We need to be careful not to delete virtual channels before all parent channels are closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants