Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] #4256: Introduce predictable ordering after too many failed view changes #4263

Merged
merged 1 commit into from
Feb 8, 2024
Merged

[fix] #4256: Introduce predictable ordering after too many failed view changes #4263

merged 1 commit into from
Feb 8, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Feb 7, 2024 •
edited
Loading

Description

Linked issue

Closes #4256
Created #4265

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 7, 2024
SamHSmith
SamHSmith previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@SamHSmith SamHSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the limit should probably be 15 instead of 5. And we should definitely remove this long term. It's an okay solution for now since it's not directly exploitable by attackers.

@mversic mversic mentioned this pull request Feb 7, 2024
Closed
SamHSmith
SamHSmith previously approved these changes Feb 7, 2024
View reviewed changes
6r1d
6r1d previously approved these changes Feb 7, 2024
View reviewed changes
@mversic mversic dismissed stale reviews from SamHSmith and 6r1d via b6925e9 February 7, 2024 12:38
@mversic
[fix] hyperledger-iroha#4256: Introduce predictable ordering after to…
d8345fa 
…o many failed view changes

Signed-off-by: Marin Veršić <[email protected]>
@mversic mversic enabled auto-merge (squash) February 7, 2024 14:04
@mversic mversic merged commit 513c0cf into hyperledger-iroha:iroha2-dev Feb 8, 2024
10 checks passed
@mversic mversic deleted the predictable_ordering_dev branch April 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamHSmith SamHSmith SamHSmith approved these changes

@6r1d 6r1d 6r1d approved these changes

@s8sato s8sato Awaiting requested review from s8sato

@Arjentix Arjentix Awaiting requested review from Arjentix

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis

@ilchu ilchu Awaiting requested review from ilchu

@pesterev pesterev Awaiting requested review from pesterev

@Erigara Erigara Awaiting requested review from Erigara

@0x009922 0x009922 Awaiting requested review from 0x009922

@DCNick3 DCNick3 Awaiting requested review from DCNick3

Assignees

@6r1d 6r1d

@SamHSmith SamHSmith

@mversic mversic

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mversic @6r1d @SamHSmith