Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove predictable ordering hack from sumeragi #4264

Closed
mversic opened this issue Feb 7, 2024 · 3 comments
Closed

Remove predictable ordering hack from sumeragi #4264

mversic opened this issue Feb 7, 2024 · 3 comments
Assignees
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Feb 7, 2024

This was introduced in #4263 to prevent consensus from operating if there is a bug in the implementation. We should make sure that consensus operation is well covered with tests and remove this backdoor

@mversic mversic added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 7, 2024
@Erigara
Copy link
Contributor

Erigara commented May 31, 2024

Going to be removed in #4518

@mversic mversic self-assigned this Jun 10, 2024
@AlexStroke AlexStroke self-assigned this Jul 8, 2024
@AlexStroke
Copy link
Contributor

I see in the code that that hack has been removed and it looks like iroha has been running successfully without it. But I can't understand if the sorting of peers has become unpredictable, which seems to be the main problem why this task was opened.

@mversic
Copy link
Contributor Author

mversic commented Jul 10, 2024

this is ok, we can close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

4 participants