Address review suggestions

husarion · Sep 10, 2024 · 5eda705 · 5eda705
1 parent 8084be8
commit 5eda705
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/panther_lights/test/test_apa102.cpp b/panther_lights/test/test_apa102.cpp
@@ -64,17 +64,14 @@ TestAPA102::TestAPA102()
   apa102_ = std::make_unique<APA102Wrapper>(spi_device_, kMockDeviceName);
 }
 
-TEST_F(TestAPA102, TestInitialization) { EXPECT_TRUE(spi_device_ != nullptr); }
-
 TEST(TestInitialization, InvalidDevices)
 {
   auto spi_device = std::make_shared<MockSPIDevice::NiceMock>();
 
   // Return -1 to simulate failed device opening
   ON_CALL(*spi_device, Open(kMockDeviceName)).WillByDefault(testing::Return(-1));
 
-  EXPECT_THROW(std::make_unique<APA102Wrapper>(spi_device, kMockDeviceName);
-               , std::ios_base::failure);
+  EXPECT_THROW(APA102Wrapper(spi_device, kMockDeviceName), std::ios_base::failure);
 }
 
 TEST(TestInitialization, SetModeFailure)
@@ -86,8 +83,7 @@ TEST(TestInitialization, SetModeFailure)
     .WillByDefault(testing::Return(-1));
   EXPECT_CALL(*spi_device, Close(testing::_)).Times(1);
 
-  EXPECT_THROW(std::make_unique<APA102Wrapper>(spi_device, kMockDeviceName);
-               , std::ios_base::failure);
+  EXPECT_THROW(APA102Wrapper(spi_device, kMockDeviceName), std::ios_base::failure);
 }
 
 TEST(TestInitialization, SetBitsFailure)
@@ -99,8 +95,7 @@ TEST(TestInitialization, SetBitsFailure)
     .WillByDefault(testing::Return(-1));
   EXPECT_CALL(*spi_device, Close(testing::_)).Times(1);
 
-  EXPECT_THROW(std::make_unique<APA102Wrapper>(spi_device, kMockDeviceName);
-               , std::ios_base::failure);
+  EXPECT_THROW(APA102Wrapper(spi_device, kMockDeviceName), std::ios_base::failure);
 }
 
 TEST(TestInitialization, SetSpeedFailure)
@@ -112,8 +107,7 @@ TEST(TestInitialization, SetSpeedFailure)
     .WillByDefault(testing::Return(-1));
   EXPECT_CALL(*spi_device, Close(testing::_)).Times(1);
 
-  EXPECT_THROW(std::make_unique<APA102Wrapper>(spi_device, kMockDeviceName);
-               , std::ios_base::failure);
+  EXPECT_THROW(APA102Wrapper(spi_device, kMockDeviceName), std::ios_base::failure);
 }
 
 TEST_F(TestAPA102, SetGlobalBrightnessRatioNegative)

diff --git a/panther_lights/test/test_lights_driver_node.cpp b/panther_lights/test/test_lights_driver_node.cpp
@@ -218,8 +218,10 @@ TEST_F(TestLightsDriverNode, FrameCBSuccess)
   lights_driver_node_->ToggleLEDControlCB(std::move(future));
 
   EXPECT_CALL(*channel_1_, SetPanel(testing::_)).Times(1);
+  EXPECT_CALL(*channel_2_, SetPanel(testing::_)).Times(1);
 
   lights_driver_node_->FrameCB(msg, channel_1_, msg->header.stamp, "channel_1");
+  lights_driver_node_->FrameCB(msg, channel_2_, msg->header.stamp, "channel_2");
 }
 
 TEST_F(TestLightsDriverNode, FrameCBTimeout)