Mock rework for concurrent usage, remove entity ID annotations, requeue after incrementHumioClusterPodRevision and refactor podReadyCountByRevision #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaaldjorMike
force-pushed
the
mike/fix-mock
branch
from
5f8f31b to
8c2c0b2
Compare
SaaldjorMike
changed the title
SaaldjorMike
force-pushed
the
mike/fix-mock
branch
2 times, most recently
from
5ca71ec to
226dd92
Compare
…ountByRevision Requeue after incrementHumioClusterPodRevision fixes a bug where the operator could in some cases create a new pod using the old revision as it did not fetch the updated HumioCluster resource before creating new pods. Refactor podReadyCountByRevision to extract the logic for what pods to should be marked as running and ensures we update only the pods that match the expected pod revision as running, as any older pod revisions should already be handled during previous iterations.
SaaldjorMike
force-pushed
the
mike/fix-mock
branch
from
226dd92 to
35fcc6f
Compare
cs-gschofield
approved these changes
Aug 16, 2024
jswoods
approved these changes
Aug 20, 2024
|
Lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: humio/cli#169