Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor where pod revision is stored #831

Closed
SaaldjorMike opened this issue Aug 2, 2024 · 1 comment · Fixed by #850
Closed

Refactor where pod revision is stored #831

SaaldjorMike opened this issue Aug 2, 2024 · 1 comment · Fixed by #850

Comments

@SaaldjorMike
Copy link
Member

Today, we store the pod revision as an annotation on the HumioCluster CR, but we should not store any content like this on the metadata/spec parts of the custom resource.

If we must store it on the HumioCluster object, we could move it to HumioClusterStatus somewhere. Maybe just extend NodePoolStatus to include the pod revision.

@SaaldjorMike SaaldjorMike changed the title Refactor where we store pod revision Refactor where pod revision is stored Aug 8, 2024
@SaaldjorMike
Copy link
Member Author

SaaldjorMike commented Aug 13, 2024

Also, we should find a better solution to storing alert/action/etc ID's than the current solution that stores it as an annotation where it may conflict with whatever sync'ing the desired state into the k8s objects. No longer needed once #843 is merged. The pod revision ID is still an issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant