Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: apply review comments on patch upload #935

Merged
merged 1 commit into from
Jan 16, 2024
Merged

ci: apply review comments on patch upload #935

merged 1 commit into from
Jan 16, 2024

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented Jan 12, 2024 •
edited
Loading

Follows up on #934.

@JohelEGP JohelEGP force-pushed the ci-patch branch 2 times, most recently from bbeb2be to bf48977 Compare January 12, 2024 20:02
@JohelEGP JohelEGP marked this pull request as ready for review January 12, 2024 20:26
@JohelEGP
Copy link
Contributor Author

@gregmarr @jarzec Thank you for the reviews.

@hsutter Now the CI uploads patches that can be run trough git apply to update the test results
when there's a mismatch between what's checked in the repository and the results of running the tests on CI.
#933 was already opened to apply those patches.

@gregmarr gregmarr mentioned this pull request Jan 12, 2024
Merged
jarzec
jarzec reviewed Jan 12, 2024
View reviewed changes
regression-tests/run-tests.sh
@@ -195,7 +195,7 @@ for test_file in $tests; do
# The source is temporarily copied to avoid issues with bash paths in cl.exe
(cd $exec_out_dir; \
cp ../../$expected_src $generated_cpp_name;
$compiler_cmd "$test_bin" \
$compiler_cmd"$test_bin" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sticking those together was necessary in the end? I think it is the cl.exe argument format that requires that, isn't it?
Please maybe add a comment about that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know.
I just reverted the change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it is not worth extra effort.

@jarzec
Copy link
Contributor

jarzec commented Jan 12, 2024

BTW the 3 failing regression test runs are currently the expected behavior. They are fixed in #933.
I am glad to see this CI is taking off 😁.

@jarzec
Copy link
Contributor

jarzec commented Jan 12, 2024

One more thing. 69 tests on Windows are sipped on the GitHub runner due to Error 1011.
@JohelEGP If I remember correctly, at an early stage of preparations of the regression test workflow you were pointing to a possible solution. I never had time to look into that. Would you be able to fix that?

@JohelEGP
Copy link
Contributor Author

That would be #897 (comment).
There's no solution there.

@jarzec jarzec mentioned this pull request Jan 12, 2024
Merged
@hsutter hsutter merged commit 63dde3e into hsutter:main Jan 16, 2024
@JohelEGP JohelEGP deleted the ci-patch branch January 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarzec jarzec jarzec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohelEGP @jarzec @hsutter