ci: upload patches

[JohelEGP]

For the result, see https://github.com/JohelEGP/cppfront/actions/runs/7505215700#artifacts.

[gregmarr]

Will this only upload if there are actually differences, or will it just upload an empty file if there are no differences?

[JohelEGP]

The former, according to the warning.

[gregmarr]

Ah, yes, missed that warning, though it would be nice if it weren't a warning at all.

# The desired behavior if no files are found using the provided path.
# Available Options:
#   warn: Output a warning but do not fail the action
#   error: Fail the action with an error message
#   ignore: Do not output any warnings or errors, the action does not fail
# Optional. Default is 'warn'
if-no-files-found:

[gregmarr]

Prevents a workflow run from failing when a job fails. Set to true to allow a workflow run to pass when this job fails.

This will make the run pass. I think you need to make this upload a new job and have it run always. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds

[gregmarr]

Another issue unrelated to this PR, the job is called regression-tests-linux-mac but also runs Windows.

[jarzec]

My bad, I must have forgotten to update.
You can fix it in is this PR.

[JohelEGP]

Can we really use jobs.<job_id>.needs?
We need to access the output patch file of the job.

[gregmarr]

Yeah, I guess I don't know. I just know that the continue-on-error means ignore failures, so that won't do what we want.

[gregmarr]

Maybe the diff needs to be a job output, not sure how that works for matrix jobs. (Update: matrix info is in that section.)
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idoutputs

[jarzec]

I think there is a simpler solution. I am testing it now.

[gregmarr]

There is one solution in #935 . It would be good to compare solutions, I think.

[jarzec]

How about:

Suggested change

	name: ${{ matrix.compiler }}-patch.diff
	name: ${{ matrix.os }}-${{ matrix.compiler }}-patch.diff

I think we might have the same compiler run on different OSes (I have that in cooking). Comparing patches for the same compiler between different systems could be another check, also of the CI. Thoughts?

BTW do you what is the retention time of artefacts on GitHub is? I guess these will be used instantly or not at all so it probably isn't an issue...

[JohelEGP]

From https://github.com/actions/upload-artifact#retention-period:

Artifacts are retained for 90 days by default.

[hsutter]

Thanks! All of this is unfamiliar to me, I appreciate the help.

[gregmarr]

@hsutter Unfortunately, this wasn't quite ready. Nothing breaking, just incomplete, and it can be addressed in a follow-up PR.