Stale content #184
Stale content #184
Conversation
It is helpful to let other Session instances know that data on the server changed and what they are rendering might be out of date. This is mostly useful when there are tabs.
|
@jayohms, is there an Android equivalent needed for this addition? From what I can see there doesn't seem to be an equivalent |
|
@joemasilotti since |
|
Excellent, thanks @jayohms! |
|
@jayohms @joemasilotti I believe that corresponding methods would be appropriate on the Android side as well, the use-case being a native screen mutating some data in which case the session(s) would have stale data. Without these methods on the Android side, native screens would not be able to mark snapshots as stale, right? |
| } else if visitable !== topmostVisit.visitable { | ||
| // Navigating backward | ||
| visit(visitable, action: .restore) | ||
| } else if isShowingStaleContent { | ||
| reload() | ||
| isShowingStaleContent = false | ||
| } else if isSnapshotCacheStale { | ||
| clearSnapshotCache() | ||
| isSnapshotCacheStale = false |
There was a problem hiding this comment.
This doesn't seem to work on the Hiking Journal demo.
The condition on L242 is different than in #173 (comment).
Why are not the flags evaluated separately after the guard statement?
There was a problem hiding this comment.
You're right, I just confirmed this PR doesn't actually fix the core issue.
I just opened #185 - thanks!
…s-response * origin/main: Fix when snapshot cache is cleared (#185) Stale content (#184) Note feature parity in CONTRIBUTING doc Provide backwards compatibility support for Turbo 7.x and Turbolinks 5 Support visit.isPageRefresh and avoid displaying the activity indicator and screenshots when the page is refreshing Support Turbo 8 same-page refreshes and include debug logging rename loadrRequest to load (#141) Add CONTRIBUTING.md (#90) Update README window.Turbo reference (#68) # Conflicts: # Source/Session/Session.swift
This PR exposes two ways of clearing stale content in turbo-ios:
markSnapshotCacheAsStale()markContentAsStale()Due to a race condition discovered in #173, clearing the snapshot cache must occur when the visitable view appears. This prevents developers from calling
clearSnapshotCache()directly fromsessionDidFinishFormSubmission(_:): #183.