Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reloadActiveSession #174

Closed

Conversation

leonvogt
Copy link
Contributor

@leonvogt leonvogt commented Feb 8, 2024

This PR will add the function reloadActiveSession to the TurboNavigator, to reload the currently active session (modal or main) without the need of performing a new visit or navigation.

If you wanted to reload the active session before this change, you first had to find out whether the modal or main session was active.
In addition, you had to pass in the sessions during initialization in order to reload it if desired.

This changes would come in handy, if you wanna reload the active session, after the app comes back to foreground or for handling internet connection loss.

…sion (modal or base) without performing a new visit or navigation
@joemasilotti
Copy link
Member

@leonvogt, is this different than #150? I feel like they both solve a similar problem. But maybe both are needed.

@leonvogt
Copy link
Contributor Author

@joemasilotti, your PR #150 looks promising. They indeed solve a similar problem.
I'm unsure at the moment if our solution is really needed if your PR is merged.

If its ok for you, I'll wait for your PR to be merged and try to accomplish the same tasks with your solution.
If everything works fine, I'll close this PR.

@joemasilotti
Copy link
Member

Closed in favor of #184 and #183.

@leonvogt leonvogt deleted the add-reload-active-session branch March 26, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants