Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the footer at the bottom on a short page #5930

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Keep the footer at the bottom on a short page #5930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/components/banner/topBanner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export function TopBanner() {
const [, error, data] = useFetchWithAbort(`system/banner/`);

return (
<>
<div>
{location.pathname === '/' && data.visible && !error && (
<div className="ph3 b--grey-light bb bg-tan top-banner-container">
<div
Expand All @@ -18,6 +18,6 @@ export function TopBanner() {
/>
</div>
)}
</>
</div>
);
}
5 changes: 4 additions & 1 deletion frontend/src/views/root.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ import { Footer } from '../components/footer';
// Components common to all routes can be included in <App>
export function Root() {
return (
<div className="flex flex-column">
<div
className="min-vh-100-l"
style={{ display: 'grid', gridTemplateRows: 'auto auto 1fr auto' }}
>
<TopBanner />
<Header />
<QueryParamProvider adapter={ReactRouter6Adapter}>
Expand Down