Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the footer at the bottom on a short page #5930

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

HelNershingThapa
Copy link
Contributor

Before:
short

After:
short-foot-footer

Had to wrap the `TopBanner` component with a div since it was conditionally rendered and a uniform value was required for `gridTemplateRows` property
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HelNershingThapa HelNershingThapa merged commit 37248dd into develop Jul 12, 2023
3 checks passed
HelNershingThapa added a commit that referenced this pull request Jul 12, 2023
HelNershingThapa added a commit that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants