Complementing PR #532 – Updated translation files and improved feedba… #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced the previous radio button style (oh-radio) with the new custom-radio-container system. - Improved accessibility by removing fixed IDs from radio inputs. - Adjusted the HTML structure to place inputs inside their corresponding labels. - Implemented the new custom-radio-checkmark styling for a more intuitive design. Reasoning: Enhancing usability, visual consistency, and preventing potential ID conflicts in multiple-question forms.
This set of changes enhances the feedback system by adding and displaying justifications for answers.
Backend: Updates to the Answer Model
✅ Added the justification field to store additional observations separately.
✅ Removed max_length=200 from JSONField (as it's not applicable).
Backend: Fixes in Saving Answers and Justifications
✅ Ensured that justifications are saved correctly and separately.
Keys fixes:
✅ Now, both the selected answer and justification are stored correctly.
✅ Prevents overwriting of existing answers in the database.
Backend: Enhancements to Feedback Overview
✅ Updated get_feedback_overview to include justifications.
✅ Ensured all answers return "selected_option" and "justification".
Backend: New API for Fetching Answers with Justifications
✅ Created a new API to return answers and justifications as JSON.
Frontend: Adjustments to Display Answers and Justifications
✅ Justifications now appear correctly in the template below the selected answer.
✅ Displays "No observation provided" if no justification is given. Implanted Condition
Final Summary
- Added justifications to the Answer model.
- Fixed saving and displaying of answers and justifications.
- Created an API to fetch answers dynamically.
- Updated templates to correctly display justifications.
The feedback system is now fully functional with proper answer justifications! 🚀
…nd improved feedback overview with justification display. Complementing PR horilla-opensource#532, enhancing translations and UI improvements in feedback overview. Added new translations for various language files in the django.po files, including Arabic, German, English, Spanish, French, and Brazilian Portuguese. These updates include messages related to observations, errors, user choices, and feedback overview. Implemented justification display in the feedback overview, ensuring that each answer now properly displays its corresponding observation. Adjusted the table structure to align justifications correctly under the "Observations" column for each employee. Improved UI consistency in the feedback review section. Added translations for "Feedback Overview" labels, ensuring they are localized in supported languages.
There is an extra {% endif %} in the code. The first {% endif %} correctly closes the condition related to the multiple-choice question. However, the second {% endif %} is unnecessary and may cause a syntax error in the template.
Suggestion: Remove the extra {% endif %} to prevent rendering issues.
|
Hi @Rmcd20 , Thank you for the update! The translation updates and UI improvements in the feedback overview enhance clarity and user experience. Excited to see these improvements in Horilla! Best Regards, |
Corrected the {% if %} and {% endfor %} structure in feedback_answer.html to prevent template rendering errors.
Fixed indentation issues and ensured proper closure of conditionals.
Improved logic for displaying the justification area when applicable.
Standardized the Likert question type condition for better readability and maintainability.
Merged branch RD.25.02.25-JustificationArea into Rd26.25_LastJust. Integrated changes from PR horilla-opensource#532, including refactored UI elements and improved justification handling. Updated feedback_overview.html to reflect recent enhancements in feedback display. Ensured consistency across feedback-related templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ck overview with justification display.
Complementing PR #532, enhancing translations and UI improvements in feedback overview.
Added new translations for various language files in the django.po files, including Arabic, German, English, Spanish, French, and Brazilian Portuguese.
These updates include messages related to observations, errors, user choices, and feedback overview.
Implemented justification display in the feedback overview, ensuring that each answer now properly displays its corresponding observation.
Adjusted the table structure to align justifications correctly under the "Observations" column for each employee.
Improved UI consistency in the feedback review section.
Added translations for "Feedback Overview" labels, ensuring they are localized in supported languages.