Merge pull request #162 from TKuh/objectify

Objectify -> CreateCapCategory*
homalg-project · Jul 11, 2023 · df8d95b · df8d95b
2 parents 42ec479 + 806fd98
commit df8d95b
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 31 deletions.
diff --git a/StableCategories/gap/FrobeniusCategories.gi b/StableCategories/gap/FrobeniusCategories.gi
@@ -305,28 +305,25 @@ InstallMethod( CreateShortSequence,
 
    function( alpha, beta )
    local s;
-
+  
    if not IsEqualForObjects( Range( alpha ), Source( beta ) ) then
-
+   
      Error( "Range of the first morphism should equal the Source of the second morphism" );
-
+   
    fi;
-
-   s := rec( o0:= Source( alpha ),
-
-             m0:= alpha,
-
-             o1 := Range( alpha ),
-
-             m1 := beta,
-
-             o2 := Range( beta ) );
-
-    ObjectifyWithAttributes( s, TheTypeCapCategoryShortSequence );
-
+
+    s:= CreateCapCategoryMorphismWithAttributes( TheTypeCapCategoryShortSequence );
+
+    s!.o0 := Source( alpha );
+    s!.m0 := alpha;
+    s!.o1 := Range( alpha );
+    s!.m1 := beta;
+    s!.o2 := Range( beta ) );
+
     AddObject( CategoryOfShortSequences( CapCategory( alpha ) ), s );
+
     return s;
-
+    
 end );
 
 InstallMethod( CreateShortExactSequence,

diff --git a/TriangulatedCategories/gap/CategoryOfTriangles.gi b/TriangulatedCategories/gap/CategoryOfTriangles.gi
@@ -252,23 +252,19 @@ end );
 InstallMethod( ExactTriangle,
           [ IsCapCategoryMorphism, IsCapCategoryMorphism, IsCapCategoryMorphism ],
   function( alpha, iota, pi )
-    local cat, triangles, t;
+    local cat, triangles;
 
     cat := CapCategory( alpha );
 
     triangles := CategoryOfExactTriangles( cat );
 
-    t := rec( );
+    return CreateCapCategoryObjectWithAttributes(
+             triangles,
+             DomainMorphism, alpha,
+             MorphismIntoConeObject, iota,
+             MorphismFromConeObject, pi
+           );
 
-    ObjectifyObjectForCAPWithAttributes(
-                t, triangles,
-                DomainMorphism, alpha,
-                MorphismIntoConeObject, iota,
-                MorphismFromConeObject, pi
-              );
-
-    return t;
-
 end );
 
 ##
@@ -367,16 +363,18 @@ InstallMethod( ExactTriangleByOctahedralAxiom,
 end );
 
 ##
-InstallMethod( MorphismOfExactTriangles, 
+InstallMethod( MorphismOfExactTriangles,
         [ IsCategoryOfExactTrianglesObject, IsCapCategoryMorphism, IsCapCategoryMorphism, IsCapCategoryMorphism, IsCategoryOfExactTrianglesObject ],
   function( s, mu_0, mu_1, mu_2, r )
     local triangles, mu;
 
     triangles := CapCategory( s );
 
-    mu := rec( 0 := mu_0, 1 := mu_1, 2 := mu_2 );
+    mu := CreateCapCategoryMorphismWithAttributes( triangles, s, r );
 
-    ObjectifyMorphismWithSourceAndRangeForCAPWithAttributes( mu, triangles, s, r );
+    mu!.0 := mu_0;
+    mu!.1 := mu_1;
+    mu!.2 := mu_2;
 
     return mu;