Merge pull request #163 from kamalsaleh/master

comply with homalg-project/CAP_project#1379
homalg-project · Jul 11, 2023 · 42ec479 · 42ec479
2 parents f23f4c6 + 3a5304e
commit 42ec479
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/ComplexesCategories/PackageInfo.g b/ComplexesCategories/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "ComplexesCategories",
 Subtitle := "Category of (co)chain complexes of an additive category",
-Version := "2023.06-03",
+Version := "2023.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 

diff --git a/ComplexesCategories/examples/notebooks/PreSheaves.ipynb b/ComplexesCategories/examples/notebooks/PreSheaves.ipynb
@@ -312,7 +312,7 @@
      "name": "stdout",
      "output_type": "stream",
      "text": [
-      "96 primitive operations were used to derive 342 operations for this category which algorithmically\n",
+      "94 primitive operations were used to derive 340 operations for this category which algorithmically\n",
       "* IsEquippedWithHomomorphismStructure\n",
       "* IsLinearCategoryOverCommutativeRing\n",
       "* IsAbelianCategoryWithEnoughInjectives\n",

diff --git a/ComplexesCategories/gap/Categories.gi b/ComplexesCategories/gap/Categories.gi
@@ -56,7 +56,11 @@ InstallGlobalFunction( COMPLEXES_CATEGORY_BY_COCHAINS_AS_TOWER,
           object_datum, morphism_constructor, morphism_datum, union_of_supports, list_of_operations_to_install, create_func_bool,
           create_func_object, create_func_morphism, supports_empty_limits, name, modeling_cat;
 
-    presh_cat := PreSheaves( INTEGERS_CAT, cat : overhead := false );
+    # temporarily #######
+    presh_cat := PreSheaves( INTEGERS_CAT, cat : overhead := false, FinalizeCategory := false );
+    presh_cat!.is_computable := false;
+    Finalize( presh_cat );
+    #####################
 
     name := Concatenation( "Bounded ", Name( presh_cat ) );
 
@@ -223,6 +227,7 @@ InstallGlobalFunction( COMPLEXES_CATEGORY_BY_COCHAINS_AS_TOWER,
                            category_morphism_filter := category_morphism_filter,
                            commutative_ring_of_linear_category := commutative_ring,
                            properties := properties,
+                           is_computable := false,
                            object_constructor := object_constructor,
                            object_datum := object_datum,
                            morphism_constructor := morphism_constructor,
@@ -236,10 +241,6 @@ InstallGlobalFunction( COMPLEXES_CATEGORY_BY_COCHAINS_AS_TOWER,
 
     SetUnderlyingCategory( modeling_cat, presh_cat );
 
-    modeling_cat!.is_computable := false;
-
-    Finalize( modeling_cat );
-
     return modeling_cat;
 
 end );
@@ -360,6 +361,8 @@ InstallMethod( ComplexesCategoryByCochains,
                    modeling_tower_morphism_datum := modeling_tower_morphism_datum,
                    only_primitive_operations := true ) : FinalizeCategory := false );
 
+    coch_cat!.is_computable := true;
+
     SetUnderlyingCategory( coch_cat, cat );
 
     ADD_FUNCTIONS_OF_EQUALITIES_TO_COCHAIN_COMPLEX_CATEGORY( coch_cat );

diff --git a/DerivedCategories/examples/notebooks/TiltingEquivalence.ipynb b/DerivedCategories/examples/notebooks/TiltingEquivalence.ipynb
@@ -451,7 +451,7 @@
      "name": "stdout",
      "output_type": "stream",
      "text": [
-      "96 primitive operations were used to derive 342 operations for this category which algorithmically\n",
+      "94 primitive operations were used to derive 340 operations for this category which algorithmically\n",
       "* IsEquippedWithHomomorphismStructure\n",
       "* IsLinearCategoryOverCommutativeRing\n",
       "* IsAbelianCategoryWithEnoughInjectives\n",