Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/1.15.2 #69

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Dev/1.15.2 #69

merged 8 commits into from
Oct 17, 2023

Conversation

alexjhawk
Copy link
Collaborator

No description provided.

@alexjhawk alexjhawk added the enhancement New feature or request label Oct 16, 2023
@alexjhawk alexjhawk marked this pull request as ready for review October 16, 2023 14:36
@alexjhawk alexjhawk requested review from TomKimsey and it-hms and removed request for TomKimsey October 16, 2023 14:36
@alexjhawk alexjhawk added the framework Improvements, additions, fixes, or documentation to/for the abstract connector framework label Oct 16, 2023
@alexjhawk alexjhawk requested a review from TomKimsey October 16, 2023 14:36
@alexjhawk alexjhawk linked an issue Oct 16, 2023 that may be closed by this pull request
Copy link
Contributor

@it-hms it-hms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my only request was to remove body for methods that do not support a body (according to the RFCs)

*
* @param url URL to make request
* @param header request header
* @param body request body
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options request does not have a body. I think it makes the most sense to remove parameter

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed (replaced with "")

*
* @param url URL to make request
* @param header request header
* @param body request body
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options request does not have a body

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed (replaced with "")

*
* @param url URL to make request
* @param header request header
* @param body request body
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEAD request does not have a body

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed (replaced with "")

*
* @param url URL to make request
* @param header request header
* @param body request body
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nobody

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed (replaced with "")

As included in Ewon documentation, I have added the
remaining supported HTTP(s) method which were not
already included in SCHttpUtility.java.
This allows for access within the HTTP(s) request
info package.
All methods supported by the Ewon RequestHTTPX
system have been supported by SCHttpUtility, thus
are supported using the request info classes/objects.
closes #67.

The CHANGELOG.md file was previously migrated
to the web documentation system, but the file
persisted unexpectedly.
@alexjhawk alexjhawk merged commit 837dec3 into main Oct 17, 2023
5 checks passed
@alexjhawk alexjhawk deleted the dev/1.15.2 branch October 17, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request framework Improvements, additions, fixes, or documentation to/for the abstract connector framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should CHANGELOG.md be deleted?
3 participants