Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance h-table #236

Merged
merged 6 commits into from
Dec 6, 2021
Merged

Enhance h-table #236

merged 6 commits into from
Dec 6, 2021

Conversation

michaelbukachi
Copy link
Collaborator

@michaelbukachi michaelbukachi commented Nov 24, 2021

What is the Purpose?

This PR:

  • Adds logic for hiding/showing columns in h-table
  • Adds the ability to use a switch when hiding/showing columns
  • Adds logic for reordering columns

What was the approach?

Briefly describe the approach used to address the issue

Are there any concerns to addressed further before or after merging this PR?

State some additional info if any. For instance running install or setting some environment variable(s)

Mentions?

@ninetteadhikari @andrewtpham

Issue(s) affected?

Related to #235
Closes #233

@vercel
Copy link

vercel bot commented Nov 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/CsWqXPDKkKzopQnMqyzpnxmWfh7X
✅ Preview: https://vue-ui-components-git-h-table-enhancements-hikaya.vercel.app

@ninetteadhikari
Copy link
Member

wow looks really good so far Michael!! 😍

@ninetteadhikari
Copy link
Member

ninetteadhikari commented Nov 29, 2021

  • Add persistence for table order, column visibility
  • this is saved per session

This is to be done in a separate PR

@ninetteadhikari ninetteadhikari added ready for development These are issues ready to be taken on. ready for review For PRs that are ready for review by code owners and removed ready for development These are issues ready to be taken on. labels Nov 29, 2021
@ninetteadhikari ninetteadhikari changed the title wip: Enhance h-table Enhance h-table Nov 29, 2021
@andrewtpham
Copy link
Member

@michaelbukachi do you think this added styling to the component could be done in this PR or should we open up in a new Issue? #233 (comment)

@michaelbukachi
Copy link
Collaborator Author

@andrewtpham I think we can do this in this PR so that we wrap up the drag and drop feature.

Copy link
Member

@andrewtpham andrewtpham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewtpham andrewtpham merged commit 1f6fbc7 into develop Dec 6, 2021
@andrewtpham andrewtpham deleted the h-table-enhancements branch December 6, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review For PRs that are ready for review by code owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Add a dropdown with checkboxes to show/hide specific columns + reorder the columns
3 participants